guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add xboing


From: John Darrington
Subject: Re: [PATCH] gnu: Add xboing
Date: Mon, 13 Oct 2014 14:43:03 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Oct 13, 2014 at 02:27:48PM +0200, Ludovic Court??s wrote:
     John Darrington <address@hidden> skribis:
     
     > * gnu/packages/games.scm (xboing): New variable.

     [...]
     
     > +    (inputs `(("libx11" ,libx11)
     > +              ("libxext" ,libxext)
     > +              ("libxpm" ,libxpm)))
     > +    (native-inputs `(("imake" ,imake)
     > +                     ("inetutils" ,inetutils)
     > +                     ("makedepend" ,makedepend)))
     
     Please align opening parenthesis and use only spaces, no tabs (for Emacs
     23 and later, .dir-locals.el normally sets it up.)

This was formatted by emacs using indent-region.  Shouldn't that do the job?
loading .dir-locals.el results in an error for me.
     
     > +    (license x11-style)))
     
     ???x11-style??? is a procedure, so it should be:
     
       (x11-style URI [COMMENT])
     
     Make sure it???s not really ???x11??? or ???expat???.

It is neither of those, although similar.  The trouble is, I don't think that 
there is a URI for the license.  It is contained in the tarball.
     
J'
     

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]