Re: [PATCH] gnu: Add cook.

[Ludovic Courtès]

John Darrington <address@hidden> skribis:

> * gnu/packages/cook.scm: New file.
> * gnu-system.am: New file cook.scm.

Looks good!

> +    (arguments
> +     `(#:parallel-build? #f ;; There are some nasty racy rules in the 
> Makefile

One semicolon only; period at the end.

> +       #:phases 
> +        (alist-cons-before
> +         'configure 'pre-conf
> +         (lambda _ 
> +             (substitute* (append '("common/env.c")
              ^^
2 extra indentation spaces here.

> +             ;; Guix's binutils is (for undeclared reasons) configured with 
> the
> +             ;; --enable-deterministic-archives flag. This has odd effects on

This is because we want bit-reproducible builds in general, and being
able to build archives deterministically is one aspect of that.  Related
issues are discussed at <https://wiki.debian.org/ReproducibleBuilds> and
<https://lists.gnu.org/archive/html/guix-devel/2013-09/msg00159.html>.

Thus, could you remove “(for undeclared reasons)”?  :-)

OK to push with those changes.

Ludo’.