Re: [PATCH 3/4] gnu: Add pt-scotch package.

[Ludovic Courtès]

Eric Bavier <address@hidden> skribis:

> From 936d49e8b0651a0e3b4674fcd34308c1d396de72 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Sat, 17 May 2014 00:31:59 -0500
> Subject: [PATCH 3/4] gnu: Add pt-scotch package.
>
> * gnu/packages/maths.scm (pt-scotch): New variable.

Looks good to me.  One question:

> +           (call-with-output-file "Makefile.inc"
> +             (lambda (port)
> +               (format port "
> +EXE =
> +LIB = .a
> +OBJ = .o
> +MAKE = make
> +AR = ar
> +ARFLAGS = -ruv
> +CCS = gcc
> +CCP = mpicc
> +CCD = gcc
> +CPPFLAGS =~{ -D~a~}
> +CFLAGS = -O2 -g $(CPPFLAGS)
> +LDFLAGS = -lz -lm -lrt -lpthread
> +CP = cp
> +LEX = flex -Pscotchyy -olex.yy.c
> +LN = ln
> +MKDIR = mkdir
> +MV = mv
> +RANLIB = ranlib
> +YACC = bison -pscotchyy -y -b y
> +"
> +                       '("COMMON_FILE_COMPRESS_GZ"
> +                         "COMMON_PTHREAD"
> +                         "COMMON_RANDOM_FIXED_SEED"
> +                         ;; TODO: Define once our MPI supports 
> MPI_THREAD_MULTIPLE
> +                         ;; "SCOTCH_PTHREAD"
> +                         ;; "SCOTCH_PTHREAD_NUMBER=2"
> +                         "restrict=__restrict")))))

Could this be factorized with Scotch?

Thanks,
Ludo’.