guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add libmikmod


From: Andreas Enge
Subject: Re: [PATCH] gnu: Add libmikmod
Date: Fri, 25 Oct 2013 22:39:47 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Oct 23, 2013 at 06:14:17PM -0400, David Thompson wrote:
> I will, but libmikmod is a library that is not directly associated
> with SDL, so I made a separate module.

Well, I am a bit wary about creating lots of files for small packages.
If it occurs essentially as a dependency of sdl, I would be happy to
package it inside the sdl module. But we do not have a coherent policy
on packages vs. modules.

Concerning style:
In 'uri', the argument 'version' to 'string-append' should be aligned
with the first argument of the line above, that is, "mirror...".
I am not sure what to do about the synopsis spanning two lines; I think
we do not have a strict 80 column policy, so it could be put into one
longer line.
After copyright, I have '??' instead of '©'; maybe the file is not
in utf-8 format?

In any case, it compiles well, and after addressing the small stylistic
comments, I support pushing it.

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]