guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

161/272: gnu: ghc-attoparsec: Enable tests and allow newer QuickCheck.


From: Ricardo Wurmus
Subject: 161/272: gnu: ghc-attoparsec: Enable tests and allow newer QuickCheck.
Date: Mon, 1 Oct 2018 06:13:38 -0400 (EDT)

rekado pushed a commit to branch master
in repository guix.

commit 0f9e74e9f7bef9157c7869cd9cb6ed50a8364e2d
Author: Timothy Sample <address@hidden>
Date:   Thu Aug 30 11:39:41 2018 -0400

    gnu: ghc-attoparsec: Enable tests and allow newer QuickCheck.
    
    * gnu/packages/haskell.scm (ghc-attoparsec)[arguments]: Enable tests and
    add a phase that patches the Cabal file to allow a newer QuickCheck and
    removes a failing test.
---
 gnu/packages/haskell.scm | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 7c5fef6..5c1bb6f 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -2909,10 +2909,19 @@ with slicing and Clang-style colored diagnostics.")
         (base32
          "0j6qcwd146yzlkc9mcvzvnixsyl65n2a68l28322q5v9p4g4g4yx"))))
     (build-system haskell-build-system)
-    ;; FIXME: at least on test fails with QuickCheck > 2.9.2.  Once upstream
-    ;; has updated the tests to work with a later version of QuickCheck we can
-    ;; re-enable them.
-    (arguments `(#:tests? #f))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-for-newer-quickcheck
+           (lambda _
+             (substitute* "attoparsec.cabal"
+               (("QuickCheck >= 2\\.7 && < 2\\.10")
+                "QuickCheck >= 2.7 && < 2.12"))
+             ;; This test fails because of the newer QuickCheck:
+             ;; <https://github.com/bos/attoparsec/issues/134>.
+             (substitute* "tests/QC/ByteString.hs"
+               ((", testProperty \"satisfyWith\" satisfyWith")
+                "")))))))
     (inputs
      `(("ghc-scientific" ,ghc-scientific)
        ("ghc-text" ,ghc-text)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]