16/21: gnu: lsof: Run tests.

[Tobias Geerinckx-Rice]

nckx pushed a commit to branch master
in repository guix.

commit 16cb3b8fe00500fc5d434cd761afbfb594cfd4c4
Author: Tobias Geerinckx-Rice <address@hidden>
Date:   Mon Feb 19 02:07:36 2018 +0100

    gnu: lsof: Run tests.
    
    * gnu/packages/lsof.scm (lsof)[arguments]: Remove untrue #:TESTS?.
    Add ‘disable-failing-tests’ and ‘check’ phases to run them.
---
 gnu/packages/lsof.scm | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/lsof.scm b/gnu/packages/lsof.scm
index 7f365f3..098242d 100644
--- a/gnu/packages/lsof.scm
+++ b/gnu/packages/lsof.scm
@@ -57,8 +57,7 @@
    (build-system gnu-build-system)
    (native-inputs `(("perl" ,perl)))
    (arguments
-    `(#:tests? #f ; no test target
-      #:phases
+    `(#:phases
       (modify-phases %standard-phases
         (replace 'unpack
           (lambda* (#:key source #:allow-other-keys)
@@ -75,6 +74,23 @@
           (lambda _
             (substitute* "Makefile"
               (("`date`") "`date address@hidden"))))
+        (add-before 'check 'disable-failing-tests
+          (lambda _
+            (substitute* "tests/Makefile"
+              ;; Fails with ‘ERROR!!! client gethostbyaddr() failure’.
+              (("(STDTST=.*) LTsock" _ prefix) prefix)
+              ;; Fails without access to a remote NFS server.
+              (("(OPTTST=.*) LTnfs"  _ prefix) prefix))))
+        (replace 'check
+          (lambda _
+            (with-directory-excursion "tests"
+              ;; Tests refuse to run on ‘unvalidated’ platforms.
+              (make-file-writable "TestDB")
+              (invoke "./Add2TestDB")
+
+              ;; The ‘standard’ tests suggest running ‘optional’ ones as well.
+              (invoke "make" "standard" "optional")
+              #t)))
         (replace 'install
           (lambda* (#:key outputs #:allow-other-keys)
             (let ((out (assoc-ref outputs "out")))