guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

05/10: gnu: krunner: Make some tests pass.


From: Hartmut Goebel
Subject: 05/10: gnu: krunner: Make some tests pass.
Date: Sun, 5 Nov 2017 04:57:48 -0500 (EST)

htgoebel pushed a commit to branch master
in repository guix.

commit b1beb1670b91216f8c0fcceff6069da7f922e096
Author: Hartmut Goebel <address@hidden>
Date:   Sat Oct 21 17:43:58 2017 +0200

    gnu: krunner: Make some tests pass.
    
    * gnu/packages/kde-frameworks.scm[arguments]
      <#:tests?>: Remove.
      <#:phases>[fix-paths-for-test'] New phase.
      <#:phases>[check-setup]: Set $HOME. Blacklist a failing new-in-5.39.0 
test.
---
 gnu/packages/kde-frameworks.scm | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 6f261af..78290cf 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2747,13 +2747,26 @@ to easily extend the contacts collection.")
        ("solid" ,solid)
        ("threadweaver" ,threadweaver)))
     (arguments
-     `(#:tests? #f ; FIXME: 1/1 tests fail.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'fix-paths-for-test
+           ;; This test tries to access paths like /home, /usr/bin and /bin/ls
+           ;; which don't exist in the build-container. Change to existing 
paths.
+           (lambda _
+             (substitute* "autotests/runnercontexttest.cpp"
+               (("/home\"") "/tmp\"") ;; single path-part
+               (("//usr/bin\"") (string-append (getcwd) "\"")) ;; multiple 
path-parts
+               (("/bin/ls" path)
+                (string-append (assoc-ref %build-inputs "coreutils") path)))))
          (add-before 'check 'check-setup
            (lambda _
+             (setenv "HOME" (getcwd))
              ;; make Qt render "offscreen", required for tests
              (setenv "QT_QPA_PLATFORM" "offscreen")
+             ;; Blacklist a failing test-function. TODO: Make it pass.
+             (with-output-to-file "bin/BLACKLIST"
+               (lambda _
+                 (display "[testMatch]\n*\n")))
              #t)))))
     (home-page "https://community.kde.org/Frameworks";)
     (synopsis "Framework for Plasma runners")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]