105/118: Remove some duplicate code

[Ludovic Courtès]

civodul pushed a commit to branch nix
in repository guix.

commit c2b65dd197a1b2e14d517b0b5ff307b149538917
Author: Eelco Dolstra <address@hidden>
Date:   Fri Oct 3 22:37:51 2014 +0200

    Remove some duplicate code
---
 nix/libstore/gc.cc  |    8 ++------
 nix/libutil/util.cc |   10 ++++++++++
 nix/libutil/util.hh |    2 ++
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc
index 4babea4..05d332f 100644
--- a/nix/libstore/gc.cc
+++ b/nix/libstore/gc.cc
@@ -301,12 +301,8 @@ static void findRoots(StoreAPI & store, const Path & path, 
unsigned char type, R
 {
     try {
 
-        if (type == DT_UNKNOWN) {
-            struct stat st = lstat(path);
-            if (S_ISDIR(st.st_mode)) type = DT_DIR;
-            else if (S_ISLNK(st.st_mode)) type = DT_LNK;
-            else if (S_ISREG(st.st_mode)) type = DT_REG;
-        }
+        if (type == DT_UNKNOWN)
+            type = getFileType(path);
 
         if (type == DT_DIR) {
             for (auto & i : readDirectory(path))
diff --git a/nix/libutil/util.cc b/nix/libutil/util.cc
index 9af42a1..ad3b3c3 100644
--- a/nix/libutil/util.cc
+++ b/nix/libutil/util.cc
@@ -223,6 +223,16 @@ DirEntries readDirectory(const Path & path)
 }
 
 
+unsigned char getFileType(const Path & path)
+{
+    struct stat st = lstat(path);
+    if (S_ISDIR(st.st_mode)) return DT_DIR;
+    if (S_ISLNK(st.st_mode)) return DT_LNK;
+    if (S_ISREG(st.st_mode)) return DT_REG;
+    return DT_UNKNOWN;
+}
+
+
 string readFile(int fd)
 {
     struct stat st;
diff --git a/nix/libutil/util.hh b/nix/libutil/util.hh
index 7e538ea..418d76d 100644
--- a/nix/libutil/util.hh
+++ b/nix/libutil/util.hh
@@ -77,6 +77,8 @@ typedef vector<DirEntry> DirEntries;
 
 DirEntries readDirectory(const Path & path);
 
+unsigned char getFileType(const Path & path);
+
 /* Read the contents of a file into a string. */
 string readFile(int fd);
 string readFile(const Path & path, bool drain = false);