[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: SRFI-64 implementation for Guile 2.0

From: Sunjoong Lee
Subject: Re: SRFI-64 implementation for Guile 2.0
Date: Sat, 21 Apr 2012 02:36:49 +0900

Hi, Ludo’;

Your implementation fails srfi-64-test.scm, a test suite for the SRFI 64.

I realize the test-error of the reference implementation has a bug;
It calls %test-error like this - (test-assert (%test-error etype expr))
but %test-error needs three arguments - (%test-error r etype expr) !!
I think you may fix it.
Humm... in %test-error (and srfi-34 srfi-35) case, (equal? type #t) is a typo of (equal? etype #t), I think.

"Store the test log in UTF-8" is a good idea.
I don't know "Display a backtrace upon error."
In my implementation on Guile and Per's reference implementation on Kawa, actual-error is loged if exception occurs like this;
  Test begin:
    test-name: "3.3. test-begin with mismatched test-end"
    source-file: "srfi-64-test.scm"
    source-line: 236
    source-form: (test-error "3.3. test-begin with mismatched test-end" #t (triv-runner (lambda () (test-begin "a") (test-assert "b" #t) (test-end "x"))))
  Test end:
    result-kind: pass
    actual-error: (misc-error #f "~A" ("bad end grojup name a but expected x") #f)
    expected-error: #t

2012/4/21 Ludovic Courtès <address@hidden>
Per Bothner <address@hidden> skribis:

> I think it would be great to get SRFI-64 into Guile.

Me too.

FWIW, I’ve been using an almost-unmodified version in several projects:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]