Re: Make system* available on MS-Windows

[Ludovic Courtès]

Eli Zaretskii <address@hidden> skribis:

> This function was disabled on Windows because its implementation used
> 'fork' and 'waitpid'.  The patch below makes system* available on
> Windows:
>
> --- libguile/simpos.c~0       2014-02-28 23:01:27 +0200
> +++ libguile/simpos.c 2014-06-30 13:55:11 +0300
> @@ -45,6 +45,10 @@
>  # include <sys/wait.h>
>  #endif
>  
> +#ifdef __MINGW32__
> +#include <process.h>

Please add a margin comment on this line reading “for waitpid” or
something like that.  Also leave a space after the sharp sign.

> @@ -115,11 +117,17 @@ SCM_DEFINE (scm_system_star, "system*",
>    if (scm_is_pair (args))
>      {
>        SCM oldint;
> -      SCM oldquit;
>        SCM sig_ign;
>        SCM sigint;
> +#ifdef SIGQUIT

Please add a margin comment saying that SIGQUIT is undefined on MinGW.

OK to push with these changes, thank you!

Ludo’.