Re: [PATCH] Bindings for ‘sendfile’

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> The sendfile commit (fbac7c6113056bc6ee85996b10bdc08325c742a5) has
> caused the following build failures on Hydra.

Thanks for the notification.

> On GNU/Linux: (both i686-linux and x86_64-linux without threads)
>
> <http://hydra.nixos.org/build/4463700/log/raw>
> <http://hydra.nixos.org/build/4463695/log/raw>
>
> checking sys/sendfile.h usability... yes
> checking sys/sendfile.h presence... yes
> checking for sys/sendfile.h... yes
> [...]
> checking for sendfile... yes
>
> ERROR: filesys.test: sendfile: pipe - arguments: ((system-error #f "~A" 
> ("Function not implemented") (38)))
> ERROR: filesys.test: sendfile: pipe with offset - arguments: ((system-error 
> #f "~A" ("Function not implemented") (38)))

Oops, fixed by 45417ab.

> On FreeBSD: (x86_64-freebsd without threads)

[...]

> On Darwin: (x86_64-darwin, both with and without threads)
>
> <http://hydra.nixos.org/build/4463702/log/raw>
> <http://hydra.nixos.org/build/4463698/log/raw>
>
> checking sys/sendfile.h usability... no
> checking sys/sendfile.h presence... no
> checking for sys/sendfile.h... no
> [...]
> checking for sendfile... yes

It turns out that the BSDs have their own flavor:

  http://www.unix.com/man-page/FreeBSD/2/sendfile/
  
https://developer.apple.com/library/mac/#documentation/Darwin/Reference/Manpages/man2/sendfile.2.html

We should support it, eventually, but for now commit 11ed427 just makes
sure we don’t mistakenly attempt to use it.

Thanks,
Ludo’.