Re: Change to write-request-line

[Andy Wingo]

On Thu 29 Sep 2011 21:45, Ian Price <address@hidden> writes:

> Two patches for the web stuff in guile. The first removes the second
> definition of 'write-uri' from module/web/http.scm. No point having two
> of them after all :-).

Probably better to remove the first one.  The second one allocates less,
catches some important error conditions, and doesn't write the fragment
component.

> The second changes 'write-request-line' to write paths rather than full
> uris. Quoth the RFC
>
>    The most common form of Request-URI is that used to identify a
>    resource on an origin server or gateway. In this case the absolute
>    path of the URI MUST be transmitted (see section 3.2.1, abs_path) as
>    the Request-URI, and the network location of the URI (authority) MUST
>    be transmitted in a Host header field.
>
> While the RFC also says that "The absoluteURI form is REQUIRED when the
> request is being made to a proxy.", reading through the code for Ruby's
> Net::HTTP and Haskell's Network.HTTP, they both seem to just use the
> path and not provide for this situation, so I've held back on including
> a #:absolute-uri? keyword to cover this.
>
> Any thoughts on this?

I guess that's OK.  Proxies probably DTRT already, and anyone who wants
something different should be able to write it fairly easily.

One thing though, you are missing the query component.  Care to post a
modifed patch?

Thanks, and sorry for the delay!

Andy
-- 
http://wingolog.org/