Re: [PATCH 4/5] [mingw]: Delete existing target file before attempting rename.

[Andy Wingo]

Hi Jan,

On Sun 01 May 2011 13:40, Andy Wingo <address@hidden> writes:

> On Tue 15 Feb 2011 16:35, Jan Nieuwenhuizen <address@hidden> writes:
>
>> From: Jan Nieuwenhuizen <address@hidden>
>>
>> 2011-02-15  Jan Nieuwenhuizen  <address@hidden>
>>
>>      * libguile/filesys.c [MINGW32] (my_rename): Add implementation
>>      that deletes target if it exists.  Fixes rename behaviour.
>
> This patch has the obvious race condition.  Why does the `rename'
> library routine not work on Win32?  The man page says
>
>     CONFORMING TO
>            4.3BSD, C89, C99, POSIX.1-2001.
>
> so I am surprised about this behavior.

C99 actually doesn't specify what happens if the destination file
exists.

I have added the `rename' gnulib module, which should fix this
particular issue (modulo canonicalize-lgpl, of course).

Andy
-- 
http://wingolog.org/