[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Portability fixes for win32 cross compiling
From: |
Ludovic Courtès |
Subject: |
Re: Portability fixes for win32 cross compiling |
Date: |
Fri, 28 May 2010 15:10:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Hi Volker,
I’m finally in the process of reviewing and applying your patches.
Volker Grabsch <address@hidden> writes:
> From 6f2b554eb5cf6a5f580689b6418fbb28d7d42c7c Mon Sep 17 00:00:00 2001
> From: Volker Grabsch <address@hidden>
> Date: Wed, 21 Apr 2010 18:45:49 +0200
> Subject: [PATCH] remove an unused and dangling #include directive
>
> ---
> libguile/objcodes.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/libguile/objcodes.c b/libguile/objcodes.c
> index 2931468..47f6f3a 100644
> --- a/libguile/objcodes.c
> +++ b/libguile/objcodes.c
> @@ -23,7 +23,6 @@
> #include <string.h>
> #include <fcntl.h>
> #include <unistd.h>
> -#include <sys/mman.h>
> #include <sys/stat.h>
> #include <sys/types.h>
> #include <assert.h>
This one is wrong: the file uses mmap(3), which is declared in
<sys/mman.h> according to
<http://www.opengroup.org/onlinepubs/9699919799/functions/mmap.html>.
This function is missing on MinGW, though, but there’s currently no
replacement in Guile. Would you like to work on it?
Thanks,
Ludo’.