guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "no duplicate" in `popen.test'


From: Neil Jerram
Subject: Re: "no duplicate" in `popen.test'
Date: Wed, 20 May 2009 18:44:23 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

>> * test-suite/tests/popen.test (open-input-pipe:no duplicate): Add
>>   another pipe from parent to child, so that the child can finish by
>>   reading from this.  Then the parent controls the child lifetime by
>>   writing to this pipe.
>>
>>   test-suite/tests/popen.test (open-output-pipe:no duplicate): Add
>>   another pipe from child to parent, and have the child finish by
>>   endlessly writing into this.  Then the parent controls the child
>>   lifetime by closing its end of the pipe, causing a broken pipe in
>>   the child.
>
> One nitpick: this entry doesn't completely follow the GNU ChangeLog
> style.  Also, the rationale for the change belongs in comments in
> `popen.test' rather than in the commit log.

Ah, you caught me; I wrote that one by hand...  I'll fix it up.

Thanks,
        Neil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]