[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: mingw patch
|
From: |
Kevin Ryde |
|
Subject: |
Re: mingw patch |
|
Date: |
Sat, 30 Apr 2005 09:54:59 +1000 |
|
User-agent: |
Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) |
Jan Nieuwenhuizen <address@hidden> writes:
>
> #ifdef __MINGW32__
> +#define socklen_t int
That'd be better as a HAVE_SOCKLEN_T.
> +#ifndef __MINGW32__
> struct ip_mreq opt_mreq;
And this would definitely be better as a HAVE_STRUCT_IP_MREQ or
whatever.
Testing for features rather than system names means you don't have to
keep adapting to each new system, and if mingw or whatever gains some
features in the future then they're automatically used.
- Re: mingw patch,
Kevin Ryde <=