Re: Critical section review

[Mikael Djurfeldt]

On Wed, 23 Mar 2005 08:16:00 +0000, Neil Jerram <address@hidden> wrote:
> OK, to get the ball rolling and fill in my understanding:
> scm_make_memoized() in debug.c has:
> 
>    SCM_CRITICAL_SECTION_START;
>    SCM_NEWSMOB (z, SCM_UNPACK (exp), SCM_UNPACK (env));
>    SCM_NEWSMOB (ans, scm_tc16_memoized, SCM_UNPACK (z));
>    SCM_CRITICAL_SECTION_END;
> 
> So:
> 
> - why do we need a critical section here?

We don't.

The above code is the result of multiple applications of query-replace
during several years of GUile development. All four lines should be
replaced by a call to SCM_RETURN_NEWSMOB.

M