guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: real == frac


From: Kevin Ryde
Subject: Re: real == frac
Date: Wed, 10 Dec 2003 06:34:38 +1000
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3 (gnu/linux)

Marius Vollmer <address@hidden> writes:
>
> Yes, that would be an improvement.  Could you implement it?

Starting with less_p,

        * numbers.c (scm_less_p): Don't convert frac to float for compares,
        that can give wrong results through rounding.

        * tests/numbers.test (<): Add tests inum/bignum/flonum/frac with frac.

For min and max, I'd be inclined to have them call scm_less_p for
their comparison, to avoid duplicating code.


Attachment: numbers.c.less-frac.diff
Description: Text document

Attachment: numbers.test.less-frac.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]