[Guile-commits] 01/01: Fix (mkstemp! "XX" 0) errors

[Andy Wingo]

wingo pushed a commit to branch stable-2.0
in repository guile.

commit ca739a29ce7bb754545f5b037014b579aec7be99
Author: Andy Wingo <address@hidden>
Date:   Wed Mar 1 14:48:37 2017 +0100

    Fix (mkstemp! "XX" 0) errors
    
    * libguile/filesys.c (scm_i_mkstemp): Validate "mode" argument as a
      string, and validate writability of template string early too.  Thanks
      to Jean Louis for the bug report.
---
 libguile/filesys.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libguile/filesys.c b/libguile/filesys.c
index e6e37b0..9bd746f 100644
--- a/libguile/filesys.c
+++ b/libguile/filesys.c
@@ -1468,6 +1468,14 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1, 1, 0,
   int open_flags, is_binary;
   SCM port;
 
+  SCM_VALIDATE_STRING (SCM_ARG1, tmpl);
+  if (!SCM_UNBNDP (mode))
+    SCM_VALIDATE_STRING (SCM_ARG2, mode);
+
+  /* Ensure tmpl is mutable.  */
+  scm_i_string_start_writing (tmpl);
+  scm_i_string_stop_writing ();
+
   scm_dynwind_begin (0);
 
   c_tmpl = scm_to_locale_string (tmpl);