Re: [PATCH 1/4] bli: don't use %pG format specifier

[Laszlo Ersek]

On 10/5/23 12:47, Oliver Steffen wrote:
> We are about to revert the unified GUID type and it's printf format
> specifier, so do use the explicit printf statement for the partition
> UUID here instread.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>  grub-core/commands/bli.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/grub-core/commands/bli.c b/grub-core/commands/bli.c
> index e0d8a54f7..2a3933925 100644
> --- a/grub-core/commands/bli.c
> +++ b/grub-core/commands/bli.c
> @@ -70,7 +70,14 @@ get_part_uuid (const char *device_name, char **part_uuid)
>        goto fail;
>      }
>  
> -  *part_uuid = grub_xasprintf ("%pG", &entry.guid);
> +  *part_uuid = grub_xasprintf (
> +              "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
> +              grub_le_to_cpu32 (entry.guid.data1),
> +              grub_le_to_cpu16 (entry.guid.data2),
> +              grub_le_to_cpu16 (entry.guid.data3),
> +              entry.guid.data4[0], entry.guid.data4[1], entry.guid.data4[2],
> +              entry.guid.data4[3], entry.guid.data4[4], entry.guid.data4[5],
> +              entry.guid.data4[6], entry.guid.data4[7]);
>    if (*part_uuid == NULL)
>      status = grub_errno;
>  

Reviewed-by: Laszlo Ersek <lersek@redhat.com>