[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] mbi: use per segment a separate relocator chunk
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v4] mbi: use per segment a separate relocator chunk |
|
Date: |
Wed, 20 Jun 2018 12:28:46 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Thu, Jun 14, 2018 at 08:29:14PM +0200, Alexander Boettcher wrote:
> Instead of setting up a all comprising relocator chunk for all segments,
> use per segment a separate relocator chunk.
>
> Currently, if the ELF is non-relocatable, a single relocator chunk will
> comprise memory (between the segments) which gets overridden by the relst()
> invocation of the movers code in grub_relocator16/32/64_boot().
>
> The overridden memory may contain reserved ranges like VGA memory or ACPI
> tables, which may lead to crashes or at least to strange boot behaviour.
>
> Signed-off-by: Alexander Boettcher <address@hidden>
LGTM. If there are no objections I will apply this patch by the end of this
week.
Thank you for doing the work.
Daniel