[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/10] make GRUB_LINUX_MAGIC_SIGNATURE architecture-specific
|
From: |
Leif Lindholm |
|
Subject: |
Re: [PATCH 03/10] make GRUB_LINUX_MAGIC_SIGNATURE architecture-specific |
|
Date: |
Thu, 15 Feb 2018 10:39:38 +0000 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Feb 15, 2018 at 11:05:16AM +0100, Daniel Kiper wrote:
> On Thu, Feb 01, 2018 at 06:18:51PM +0000, Leif Lindholm wrote:
> > Rename GRUB_LINUX_MAGIC_SIGNATURE GRUB_LINUX_I386_MAGIC_SIGNATURE,
>
> Missing "to" between GRUB_LINUX_MAGIC_SIGNATURE and
> GRUB_LINUX_I386_MAGIC_SIGNATURE.
Both forms are valid (it wasn't a typo).
> I will fix it during commit.
But I don't mind if you change it :)
> > to be usable in code that supports more than one image type.
> >
> > Signed-off-by: Leif Lindholm <address@hidden>
>
> Otherwise Reviewed-by: Daniel Kiper <address@hidden>
Thanks!
/
Leif
- [PATCH 00/10] various cleanup, Leif Lindholm, 2018/02/01
- [PATCH 06/10] arm64: align linux kernel magic macro naming with i386, Leif Lindholm, 2018/02/01
- [PATCH 07/10] arm: switch linux loader to linux_arm_kernel_header struct, Leif Lindholm, 2018/02/01
- [PATCH 10/10] commands/file: use definitions from arm64/linux.h, Leif Lindholm, 2018/02/01
- [PATCH 05/10] arm64: align linux kernel header struct naming with i386, Leif Lindholm, 2018/02/01
- [PATCH 09/10] commands/file: use definitions from arm/linux.h, Leif Lindholm, 2018/02/01