grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] sparc64: Add blocklist GPT support for SPARC


From: Daniel Kiper
Subject: Re: [PATCH v2] sparc64: Add blocklist GPT support for SPARC
Date: Wed, 18 Oct 2017 15:58:28 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Oct 12, 2017 at 12:02:42PM +0000, Vladimir 'phcoder' Serbinenko wrote:
> On Thu, Oct 12, 2017, 14:00 Daniel Kiper <address@hidden> wrote:
>
> > On Mon, Oct 09, 2017 at 08:42:04AM -0600, Eric Snowberg wrote:
> > > > On Oct 9, 2017, at 5:57 AM, Daniel Kiper <address@hidden> wrote:
> > > > On Fri, Oct 06, 2017 at 02:58:30PM -0600, Eric Snowberg wrote:
> > > >>> On Oct 6, 2017, at 8:04 AM, Daniel Kiper <address@hidden>
> > wrote:
> > > >>> On Thu, May 11, 2017 at 06:25:24PM -0700, Eric Snowberg wrote:
> > > >>>> Add block-list GPT support for SPARC.  The OBP "load" and "boot"
> > methods
> > > >>>> are partition aware and neither command can see the partition
> > table. Also
> > > >>>> neither command can address the entire physical disk. When the
> > install
> > > >>>> happens, grub generates the block-list entries based on the
> > beginning of the
> > > >>>> physical disk, not the beginning of the parition. This patch fixes
> > the
> > > >>>> block-list entries so they match what OBP expects during boot for a
> > GPT
> > > >>>> disk.
> > > >>>>
> > > >>>> T5 and above now supports GPT as well as VTOC.
> > > >>>>
> > > >>>> This patch has been tested on T5-2 and newer SPARC systems.
> > > >>>>
> > > >>>> Signed-off-by: Eric Snowberg <address@hidden>
> > > >>>> ---
> > > >>>> Changes in v2:
> > > >>>> Do all GPT offset calculations in setup
> > > >>>> ---
> > > >>>> util/setup.c |   26 +++++++++++++++++++++++---
> > > >>>> 1 files changed, 23 insertions(+), 3 deletions(-)
> > > >>>>
> > > >>>> diff --git a/util/setup.c b/util/setup.c
> > > >>>> index 8aa5a39..8036307 100644
> > > >>>> --- a/util/setup.c
> > > >>>> +++ b/util/setup.c
> > > >>>> @@ -138,6 +138,9 @@ struct blocklists
> > > >>>> #ifdef GRUB_SETUP_BIOS
> > > >>>>  grub_uint16_t current_segment;
> > > >>>> #endif
> > > >>>> +#ifdef GRUB_SETUP_SPARC64
> > > >>>> +  grub_uint64_t gpt_offset;
> > > >>>> +#endif
> > > >>>
> > > >>> This does not seem to be used below???
> > > >>
> > > >> After looking into this further, I don???t see a problem...
> > > >
> > > > Sorry, it is a problem. It declares the gpt_offset variable here???
> > >
> > > No, it is not declaring a variable here.  It is adding a member
> > > to a structure, the same way x86 does with current_segment.
> >
> > Ugh... Sorry, you are right. Patch is formated in a bit unfortunate way
> > and I have to look at original file to spot it. So, in this situation LGTM.
> > If there are no objections then I will apply it in a week or so.
> >
> I'd like to review this particular patch first

Vladimir, are you OK with that patch? I am going to apply
this by the end of this week.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]