[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] i386/x86_64: make linux header definitions arch-specific
|
From: |
Leif Lindholm |
|
Subject: |
Re: [PATCH 1/4] i386/x86_64: make linux header definitions arch-specific |
|
Date: |
Wed, 13 Sep 2017 09:43:03 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Sep 13, 2017 at 05:45:58AM +0200, Daniel Kiper wrote:
> Hi Leif,
>
> Sorry for late reply but I am traveling. I should be
> more responsive starting from next week.
>
> On Tue, Sep 05, 2017 at 09:41:11PM +0100, Leif Lindholm wrote:
> > Rename GRUB_LINUX_MAGIC_SIGNATURE -> GRUB_LINUX_I386_MAGIC_SIGNATURE
> > and linux_kernel_header -> linux_i386_kernel_header.
>
> I think that this begs for 2 separate patches.
Sure.
> > Also change the include guard on grub/i386/linux.h to prevent clashes
> > when including multiple linux.h headers (like in commands/file.c).
>
> Third patch.
Sure.
> > Signed-off-by: Leif Lindholm <address@hidden>
> > ---
> >
> > OK, so one question here: in order to follow existing style, I have kept
> > to the existing linux_ format. Is that the appropriate prefix, or should
> > this be grub_linux_ like I originally used in the ARM series?
>
> I prefer linux_.
Sure.
> > Regardless, I intend to align the ARM patches to whatever format ends up
> > being used for this patch.
>
> Please do.
>
> Daniel