Re: [PATCH v5 2/2] efi: Free malloc regions on exit

[Leif Lindholm]

On Wed, Aug 30, 2017 at 02:11:59PM +0200, Daniel Kiper wrote:
> On Tue, Aug 29, 2017 at 09:26:48PM +0200, Alexander Graf wrote:
> > +{
> > +  grub_efi_boot_services_t *b;
> > +  struct efi_allocation *alloc;
> > +  grub_efi_status_t status;
> > +
> > +  b = grub_efi_system_table->boot_services;
> > +  status = efi_call_3 (b->allocate_pool, GRUB_EFI_LOADER_DATA,
> > +                           sizeof(*alloc), (void**)&alloc);
> > +  if (status == GRUB_EFI_SUCCESS)
> > +    {
> > +      alloc->next = efi_allocated_memory;
> > +      alloc->start_addr = address;
> > +      alloc->pages = pages;
> > +      efi_allocated_memory = alloc;
> > +    }
> > +  else
> > +      grub_printf ("Could not malloc memory to remember EFI allocation. "
> > +                   "Exiting grub2 won't free all memory.\n");
> 
> s/grub2/GRUB2/

Well, GRUB. Grub2 is a distro-ism.
We shouldn't have to update individual message strings when we bump
revisions.

/
    Leif