Re: [PATCH] Implement checksum verification for gunzip

[Stefan Fritsch]

On Wed, 4 May 2016, Stefan Fritsch wrote:

> On Tue, 3 May 2016, Andrei Borzenkov wrote:
> 
> > 01.05.2016 15:32, Stefan Fritsch пишет:
> > > This implements the crc32 check for the gzip format. Support for zlib's
> > > adler checksum is not included, yet.
> > >     
> > 
> > That looks fine, but it is something for post 2.02. Ping if it gets forgot.
> 
> Sure.

Ping. 2.02 is released now. Should I resend the patch? It still applies.

Cheers,
Stefan

> > > diff --git a/contrib/grub2/grub-core/io/gzio.c 
> > > b/contrib/grub2/grub-core/io/gzio.c
> > > index 0f2ea6b..432f0aa 100644
> > > --- a/contrib/grub2/grub-core/io/gzio.c
> > > +++ b/contrib/grub2/grub-core/io/gzio.c
> > > @@ -43,6 +43,7 @@
> > >  #include <grub/dl.h>
> > >  #include <grub/deflate.h>
> > >  #include <grub/i18n.h>
> > > +#include <grub/crypto.h>
> > >  
> > >  GRUB_MOD_LICENSE ("GPLv3+");
> > >  
> > > @@ -94,6 +95,14 @@ struct grub_gzio
> > >    struct huft *tl;
> > >    /* The distance code table.  */
> > >    struct huft *td;
> > > +  /* The checksum algorithm */
> > > +  const gcry_md_spec_t *hdesc;
> > 
> > Are different algorithms possible?
> > 
> 
> Yes. The struct is shared by zlib and gzip, and zlib uses adler instead of 
> crc32.