my ongoing attempt...

[Dryden Personalis]

I was checking out the patch attempt I had done in May and rebasing it 
on top of current Git.

There were lines in lvm.c I had thought about changing, just some 
housekeeping so to speak.

Turns out those very same things had already been changed by Andrei back 
in May 2015:

commit 5082ea618439fe59956d071777be0c9c74fbbcf5
Author: Andrei Borzenkov <address@hidden>
Date:   Wed May 13 09:47:17 2015 +0300

    remove extra newlines in grub_util_* strings

    grub_util_{info,warn,error} already add trailing newlines, so remove
    them from format strings. Also trailing full stops are already 
added.



But Ubuntu (16.04) still ships with a version older than that, 
apparently.

I would never have fathomed such a thing, my apologies.


I also hope you don't mind me using a developer nick here. My real name 
has the initials of B.S., which is no problem in Dutch, but not so nice 
in English :P.

One of many reasons I guess.

Anyway I came across two minor things that should be no issue here:

=====================

diff --git a/include/grub/emu/hostdisk.h b/include/grub/emu/hostdisk.h
index e006f0b..2eb0f0c 100644
--- a/include/grub/emu/hostdisk.h
+++ b/include/grub/emu/hostdisk.h
@@ -1,4 +1,4 @@
-/* biosdisk.h - emulate biosdisk */
+/* hostdisk.h - emulate biosdisk */
 /*
  *  GRUB  --  GRand Unified Bootloader
  *  Copyright (C) 2002,2007  Free Software Foundation, Inc.
diff --git a/util/setup.c b/util/setup.c
index 8aa5a39..902e4a9 100644
--- a/util/setup.c
+++ b/util/setup.c
@@ -1,4 +1,4 @@
-/* grub-setup.c - make GRUB usable */
+/* setup.c - make GRUB usable */
 /*
  *  GRUB  --  GRand Unified Bootloader
  *  Copyright (C) 
1999,2000,2001,2002,2003,2004,2005,2006,2007,2008,2009,2010,2011  Free 
Software Foundation, Inc.

=====================

But I don't know what "emulate biosdisk" should be ;-).

Regards.

namechanges.patch
Description: Text Data