Re: [PATCH] Install to LVM PVs

[Dryden Personalis]

Andrei Borzenkov schreef op 08-05-2016 11:23:
> 08.05.2016 07:53, Dryden Personalis пишет:
> > +    if (is_lvm)
> > +      err = grub_util_lvm_embed (dest_dev->disk, &nsec, maxsec,
> > +                                GRUB_EMBED_PCBIOS, &sectors);
>
> PV label may be in the first sector. In this case label will be
> overwritten later by boot image. This needs additional check.

Is that only true for the first sector? I saw it checks the first 4. So 
I don't know what it does by default?

pvcreate will not work on disks that have a partition, but they are okay 
with having a label but no partitions.

the man page suggests wiping the first sector, but it says nothing about 
where it will install itself.

You are suggesting to check whether PV header is in 1-3, and not proceed 
if it is in 0.