Re: [PATCH 2/2] arm efi: Use fdt from firmware when available

[Leif Lindholm]

Apologies for delay, was busy at Linaro Connect during the week, and
have been sleeping since I got back home yesterday.

This patch could with some stretch of the imagination be considered a
bugfix for the arm-efi port.

I _should_ hack together an update to arm-efi to use the arm64 Linux
loader (booting via the kernel EFI Stub) on kernels supporting it, but
since this support only went into v4.5-rc1, there is a use-case for
supporting both ways on 32-bit.

That's basically a roundabout way of saying "I wish we could just drop
the separate arm-efi Linux loader, but I don't think we can, and this
improves it to make it work more like the stub loader does".

Which is basically a roundabout way of saying "yes".

/
    Leif

On Thu, Mar 10, 2016 at 09:00:32PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> Is it something relevant for 2.02 or not?
> 
> On Monday, February 29, 2016, Alexander Graf <address@hidden> wrote:
> 
> > If EFI is nice enough to pass us an FDT using configuration tables on 32bit
> > ARM, we should really try and make use of it.
> >
> > Signed-off-by: Alexander Graf <address@hidden <javascript:;>>
> > ---
> >  include/grub/arm/linux.h | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/include/grub/arm/linux.h b/include/grub/arm/linux.h
> > index 059dbba..a66caad 100644
> > --- a/include/grub/arm/linux.h
> > +++ b/include/grub/arm/linux.h
> > @@ -40,11 +40,7 @@
> >  # define LINUX_PHYS_OFFSET        (0x00008000)
> >  # define LINUX_INITRD_PHYS_OFFSET (LINUX_PHYS_OFFSET + 0x02000000)
> >  # define LINUX_FDT_PHYS_OFFSET    (LINUX_INITRD_PHYS_OFFSET - 0x10000)
> > -static inline grub_addr_t
> > -grub_arm_firmware_get_boot_data (void)
> > -{
> > -  return 0;
> > -}
> > +# define grub_arm_firmware_get_boot_data
> > (grub_addr_t)grub_efi_get_firmware_fdt
> >  static inline grub_uint32_t
> >  grub_arm_firmware_get_machine_type (void)
> >  {
> > --
> > 1.8.5.6
> >
> >
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden <javascript:;>
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> >
> 
> 
> -- 
> Regards
> Vladimir 'phcoder' Serbinenko