[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] Add a module for retrieving SMBIOS information
|
From: |
Andrei Borzenkov |
|
Subject: |
Re: [PATCH v5 2/2] Add a module for retrieving SMBIOS information |
|
Date: |
Tue, 8 Mar 2016 08:02:31 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
03.03.2016 07:13, David Michael пишет:
> On Wed, Mar 2, 2016 at 2:08 PM, Andrei Borzenkov <address@hidden> wrote:
>> Two nitpicks otherwise looks good. Thanks!
>
> Thanks for reviewing these again. I agree with your suggestions, but
> do they warrant another updated patch, or can those changes just be
> squashed onto this commit?
>
Could you send final version with all changes applied; it makes it
easier to review and apply.
> Also, since sending this, Leif Lindholm has proposed a patch for
> sharing the EFI table lookup code, which is functionality used by this
> module. Is that something that would be included in 2.02? Should I
> make a quick update to this to use the new function?
>
That's probably post-2.02 change.