|
| From: | Andrei Borzenkov |
| Subject: | Re: [PATCH v4 02/11] xen: avoid memleaks on error |
| Date: | Thu, 25 Feb 2016 20:38:24 +0300 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
22.02.2016 11:24, Daniel Kiper пишет: > > Are you sure that grub_errno is always set to GRUB_ERR_NONE > if any GRUB2 function finished successfully? grub_errno is reset by command parser before command execution (or after previous command finished actually). During command execution there is no guarantee that this happens; sometimes grub_errno is explicitly reset to suppress subsequent errors but in general errors are just passed through. > Maybe you should > set initialize grub_errno with GRUB_ERR_NONE at the beginning > of parse_xen_guest()? > > Daniel > > _______________________________________________ > Grub-devel mailing list > address@hidden > https://lists.gnu.org/mailman/listinfo/grub-devel >
| [Prev in Thread] | Current Thread | [Next in Thread] |