Re: [PATCH] net: reset nb->data per dns record lookup loop

[Andrei Borzenkov]

17.11.2015 22:07, Josef Bacik пишет:
> We were resetting nb->data every time we tried a new server, but we need to do
> it every time we try for a different record, otherwise we don't end up falling
> back to the A record properly.  Thanks,
>
> Signed-off-by: Josef Bacik <address@hidden>
> ---
>   grub-core/net/dns.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/net/dns.c b/grub-core/net/dns.c
> index c356318..9291aec 100644
> --- a/grub-core/net/dns.c
> +++ b/grub-core/net/dns.c
> @@ -570,11 +570,11 @@ grub_net_dns_lookup (const char *name,
>             grub_err_t err2;
>             if (!sockets[j])
>               continue;

Could you rebase to current head?

> -          nb->data = nbd;
>
>             grub_size_t t = 0;
>             do
>               {
> +              nb->data = nbd;
>                 if (servers[j].option == DNS_OPTION_IPV4 ||
>                    ((servers[j].option == DNS_OPTION_PREFER_IPV4) && (t++ == 
> 0)) ||
>                    ((servers[j].option == DNS_OPTION_PREFER_IPV6) && (t++ == 
> 1)))