grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix extraous comma in printf


From: Michael Chang
Subject: [PATCH] Fix extraous comma in printf
Date: Thu, 11 Sep 2014 18:27:14 +0800

This patch is to get intended output from printf shell command, as the
comma is not used as separator for it's arguments, they will eventually
be outputted together with the variables.

Though it does not affect or break any function currently, I'd like to
address this hidden problem and hope to get some attention of it.

Thanks.
---
 grub-core/osdep/unix/config.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/grub-core/osdep/unix/config.c b/grub-core/osdep/unix/config.c
index f4b0bb4..65effa9 100644
--- a/grub-core/osdep/unix/config.c
+++ b/grub-core/osdep/unix/config.c
@@ -105,8 +105,8 @@ grub_util_load_config (struct grub_util_config *cfg)
       *ptr++ = *iptr;
     }
 
-  strcpy (ptr, "'; printf 
\"GRUB_ENABLE_CRYPTODISK=%s\\nGRUB_DISTRIBUTOR=%s\\n\", "
-         "\"$GRUB_ENABLE_CRYPTODISK\", \"$GRUB_DISTRIBUTOR\"");
+  strcpy (ptr, "'; printf 
\"GRUB_ENABLE_CRYPTODISK=%s\\nGRUB_DISTRIBUTOR=%s\\n\" "
+         "\"$GRUB_ENABLE_CRYPTODISK\" \"$GRUB_DISTRIBUTOR\"");
 
   argv[2] = script;
   argv[3] = '\0';
-- 
1.7.3.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]