grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues


From: Ram Pai
Subject: Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues
Date: Wed, 2 Apr 2014 10:48:34 -0700
User-agent: Mutt/1.5.20 (2009-12-10)

On Wed, Apr 02, 2014 at 09:19:59PM +0400, Andrey Borzenkov wrote:
> В Wed, 2 Apr 2014 10:06:05 -0700
> Ram Pai <address@hidden> пишет:
> 
> > On Tue, Apr 01, 2014 at 09:27:19PM +0400, Andrey Borzenkov wrote:
> > > В Wed, 26 Feb 2014 10:31:10 -0800
> > > Ram Pai <address@hidden> пишет:
> > > 
> > > > From: Anton Blanchard <address@hidden>
> > > > 
> > > >  Fix powerpc setjmp/longjmp 64bit issues
> > > > 
> > > > Signed-off-by: Ram Pai <address@hidden>
> > > > From:  Anton Blanchard <address@hidden>
> > > > ---
> > > >  grub-core/lib/powerpc/setjmp.S | 94 
> > > > +++++++++++++++++++++++-------------------
> > > >  1 file changed, 52 insertions(+), 42 deletions(-)
> > > > 
> > > > diff --git a/grub-core/lib/powerpc/setjmp.S 
> > > > b/grub-core/lib/powerpc/setjmp.S
> > > > index 716b563..51fcae9 100644
> > > > --- a/grub-core/lib/powerpc/setjmp.S
> > > > +++ b/grub-core/lib/powerpc/setjmp.S
> > > > @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE "GPLv3+"
> > > >  
> > > >         .text
> > > >  
> > > > +#if defined( __powerpc64__ ) || defined( __powerpc64le__ )
> > > 
> > > Where is __powerpc64__ defined? Your previous patch adds only
> > > __powerpc64le__ and it does exist in current code as well?
> > 
> > It is already defined even prior to this patch series.
> 
> Where?

just checked. Looks like it is defined automatically by the compiler 
automatically when -m64 is
specified.

RP




reply via email to

[Prev in Thread] Current Thread [Next in Thread]