Re: conflicting types for 'grub_list_push' on MinGW (include loop)

[Andrey Borzenkov]

В Mon, 13 Jan 2014 23:00:22 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:

> On 13.01.2014 19:33, Colin Watson wrote:
> > On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote:
> >> I'm not sure what to do here. list.h needs misc.h apparently only for
> >> definition of ATTRIBUTE_ERROR which in turn does  not appear to be used
> >> anywhere else. This is not fatal so may be can be ignored for now, but
> >> still would be nice to clean up.
> > 
> > Maybe we could instead move grub_strtol into grub-core/kern/misc.c,
> > after which we'd no longer need to include <grub/i18n.h> from
> > <grub/misc.h>?
> > 
> grub_strtol isn't used in core so shouldn't be in kernel.
> 
> 

Unless there is some redefinition, it seems to be used almost only in
core? Is it wrong?

address@hidden:~/src/grub> grep -rlw grub_strtol .
./grub-core/gfxmenu/gui_circular_progress.c
./grub-core/gfxmenu/gui_list.c
./grub-core/lib/syslinux_parse.c
./include/grub/misc.h
./ChangeLog
address@hidden:~/src/grub>

signature.asc
Description: PGP signature