Re: ext4 inline data (Re: grub-2.02~beta1 happened)

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 19.12.2013 17:05, Andrey Borzenkov wrote:
> В Thu, 19 Dec 2013 10:53:54 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
>> On 19.12.2013 07:38, Andrey Borzenkov wrote:
>>> On Thu, Dec 19, 2013 at 5:51 AM, Vladimir 'φ-coder/phcoder' Serbinenko
>>> <address@hidden> wrote:
>>>> Hello, all. I've just uploaded 2.02~beta1. This also means that we're
>>>> now in freeze. I'm willing to consider exceptions on case-by-case basis
>>>> but it would be exceptions.
>>>
>>> You did not answer my question whether I should commit ext4 inline
>>> data support. Do I understand it correctly you do not plan to include
>>> it in release?
>>>
>> There were several problems with it:
>> - Apparently the format isn't completely stable. A discussion dated of
>> December 2013 proposes to change format in order to squeeze in a little
>> bit more data.
> 
> I suspect we'll need to support both then, just like kernel. But that
> can live in a branch and be tested downstream first, when e2fsprogs
> with inline support is finally available.
> 
Yes, and it would be good to add it to ext234_test.
This ever chaging format is tricky one to handle. After release we'll
probably be able to merge it to master.
>> - Patch would crash on ARM due to misaligned access
>> - There are memory leaks.
>> For 2nd and 3rd I've uploaded fixes to andrey/ext4_inline_data but then
>> because lack of support in version packaged by Debian sid I couldn't
>> test it.
> 
> Thank you! Unfortunately I have only x86 to test.
> 
cross-compiling for ARM already catches most of them due to -Wcast-align
as long as you don't cast pointer to int or reverse or use void *.
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

signature.asc
Description: OpenPGP digital signature