[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] second attempt to fix using grub device name as install
From: |
Andrey Borzenkov |
Subject: |
Re: [PATCH 2/2] second attempt to fix using grub device name as install device |
Date: |
Sat, 7 Dec 2013 13:40:22 +0400 |
В Sat, 07 Dec 2013 09:47:44 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> On 07.12.2013 09:44, Andrey Borzenkov wrote:
> > + install_device[grub_strlen (install_device) - 1] = '\0';
> > + install_drive = xstrdup (install_device + 1);
> > + install_device[grub_strlen (install_device) - 1] = ')';
> > + }
> Bad code. You forgot that grub_strlen changes with your operations. You
> need to keep explicit pointer.
>
>
Oops. Any reason "our" gnulib is missing xstrndup? It is not the only
place where it will make things more simple and readable.
signature.asc
Description: PGP signature
- [PATCH] Fix grub-install with OS device name, Colin Watson, 2013/12/04
- Re: [PATCH] Fix grub-install with OS device name, Jonathan McCune, 2013/12/04
- Re: [PATCH] Fix grub-install with OS device name, Colin Watson, 2013/12/04
- Re: [PATCH] Fix grub-install with OS device name, arvidjaar, 2013/12/05
- Re: [PATCH] Fix grub-install with OS device name, Andrey Borzenkov, 2013/12/05
- [PATCH 1/2] revert 69ca97c820, it broke using OS device name as install device, Andrey Borzenkov, 2013/12/07
- [PATCH 2/2] second attempt to fix using grub device name as install device, Andrey Borzenkov, 2013/12/07
- Re: [PATCH 2/2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/07
- Re: [PATCH 2/2] second attempt to fix using grub device name as install device,
Andrey Borzenkov <=
- Re: [PATCH 2/2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/07
- [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Andrey Borzenkov, 2013/12/07
- Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/07
- Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Andrey Borzenkov, 2013/12/07
- Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/07