[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH,HURD] Fix grub-probe with userland partition support
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH,HURD] Fix grub-probe with userland partition support |
|
Date: |
Mon, 23 Apr 2012 11:07:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 22.04.2012 20:24, Samuel Thibault wrote:
> + sprintf (devpath + strlen (devpath), "s%d", winner_part + 1);
> + }
Also:
- It's probably wrong to assume that Hurd partition numbering is the
same as GRUB's, especially if several partmaps are present.
- Don't use x + strlen (x), keep pointer instead, you can easily do it
if you replace strcpy with stpcpy
- sprintf is banned in GRUB code. Use snprintf
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, (continued)
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, Samuel Thibault, 2012/04/24
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, Vladimir 'φ-coder/phcoder' Serbinenko, 2012/04/24
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, Samuel Thibault, 2012/04/24
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, Vladimir 'φ-coder/phcoder' Serbinenko, 2012/04/25
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, Samuel Thibault, 2012/04/25
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, Vladimir 'φ-coder/phcoder' Serbinenko, 2012/04/27
- Re: [PATCH,HURD] Fix grub-probe with userland partition support, Samuel Thibault, 2012/04/30
Re: [PATCH,HURD] Fix grub-probe with userland partition support,
Vladimir 'φ-coder/phcoder' Serbinenko <=