grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] Make knetbsd pass the root device


From: Grégoire Sutre
Subject: Re: [patch] Make knetbsd pass the root device
Date: Thu, 29 Sep 2011 00:25:19 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13

On 09/28/2011 10:57 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
On 28.09.2011 19:56, Grégoire Sutre wrote:
+  grub_uint64_t buf[(GRUB_DISK_SECTOR_SIZE + 7) / 8];
No need for + 7 since you know that GRUB_DISK_SECTOR_SIZE is divisible
by 8. Other than this patch looks good. Go ahead

Thanks, committed.

> (I assume that you checked that it works well with NetBSD)

I made a number of tests, with various partitioning schemes,
mainly with NetBSD -current, but I also made a few with the
latest stable release.

Grégoire



reply via email to

[Prev in Thread] Current Thread [Next in Thread]