[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Reset grub_errno after embedding test on non-fatal failures
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] Reset grub_errno after embedding test on non-fatal failures |
|
Date: |
Mon, 26 Sep 2011 22:32:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13 |
On 26.09.2011 22:27, Mario Limonciello wrote:
> - return GRUB_ERR_NONE;
> + return grub_error(GRUB_ERR_NONE,"");
This is obviously the wrong place. It's the successful return clause. if
grub_errno isn't 0 at this point then the code is wrong somewhere else.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature