Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417)

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 06.04.2011 17:31, Alexander Kurtz wrote:
> Am Dienstag, den 05.04.2011, 23:27 +0200 schrieb Nicolas de Pesloüan:
>> Le 05/04/2011 22:53, Colin Watson a écrit :
>>
>>> On Unix-like systems, though, and particularly when it comes to shell,
>>> this often involves knowing about historical behaviour as well as
>>> current behaviour.
>> Thanks Colin, for clarifying this!!
>>
>> Very appreciated.
> Now that we've all learned something new again (at least I have ;-) ),
> let's go back to the main topic:
>
> What do you think of the patch itself?
The (big) patch is mostly fine except:
-Please don't add brances where not needed
-Please don't add quoting to constants like x since x or "x" are
strictly identical.
> Best regards
>
> Alexander Kurtz
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature