|
From: | Nicolas de Pesloüan |
Subject: | Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417) |
Date: | Tue, 05 Apr 2011 21:16:13 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110303 Icedove/3.0.11 |
Le 05/04/2011 14:55, Alexander Kurtz a écrit :
Hi, currently you can't use an image which has whitespace in its filename as GRUB background image because grub-mkconfig_lib lacks proper variable quoting (see [1] for more information). I've attached three patches which should fix this problem: quote-big.patch: This patch fixes the problem with the minimal set of changes. quote-medium.patch: This patch adds proper quoting wherever it is safe to do so. quote-small.patch This patch additionally adds quoting in cases like this: ${grub-probe} --foo --bar => "${grub-probe}" --foo --bar This breaks things if ${grub-probe} contains additional parameters. Please note that I already submitted similar patches a while ago[2], but these are a little outdated now. The attached patches have been refreshed and should apply cleanly to the current trunk. What do you think?
Why do you use construct like "${x}" instead of "$x"? ${x} is useless, unless the character that follow $x might be part of the variable name: "${x}y" is obviously different from "$xy", but "${x}" is identical to "$x". Nicolas.
Best regards Alexander Kurtz [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612417#5 [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612417#10 _______________________________________________ Grub-devel mailing list address@hidden http://lists.gnu.org/mailman/listinfo/grub-devel
[Prev in Thread] | Current Thread | [Next in Thread] |