Re: [PATCH] Trunk: usbtrans.c - wrong max packet size for bulk transfer

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 09/23/2010 10:27 PM, Aleš Nesrsta wrote:
>       code works on on 64 bits architectures.  */
> -  u->td = (grub_uhci_td_t) grub_memalign (4096, 4096*2);
> +  u->td = (grub_uhci_td_t) grub_memalign (4096, 32*N_TD);
>    if (! u->td)
>      goto fail;
>   
Could you use sizeof while on it?

-      endpdesc = grub_usb_get_endpdescriptor (dev, 0);
+      endpdesc = grub_usb_get_endpdescriptor (dev, endpoint);
It's hard to see the context of this change. Could you use --diff-options=-p in 
the future?
Other than that this patch is ok for trunk
 



-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko