grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] transparent file reader


From: Seth Goldberg
Subject: Re: [PATCH] transparent file reader
Date: Tue, 16 Feb 2010 11:38:28 -0800 (PST)
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)


How do consumers of this interface determine the underlying cause of the problem? Sometimes, more layering creates more problems than it solves. Think about how you determine the message to display when getting a return value from a function.

 --S

Quoting Szymon Janc, who wrote the following on Tue, 16 Feb 2010:

Hello,

Attached patch makes file reader transparent. It should make adding new filters
to file reader easier.

- gzio.h is gone
- gzio is no more transparent, transparency is handled in grub_file_open()
- renamed GRUB_ERR_BAD_GZIP_DATA to GRUB_ERR_BAD_IOFILTER_DATA, it will be
used by other ios like xzio


What do You think about it?


--
Szymon K. Janc
address@hidden // GG: 1383435





reply via email to

[Prev in Thread] Current Thread [Next in Thread]