grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

comment about grub_error, capitalisation and one commit


From: Carles Pina i Estany
Subject: comment about grub_error, capitalisation and one commit
Date: Wed, 20 Jan 2010 23:37:38 +0000
User-agent: Mutt/1.5.20 (2009-06-14)

Hi,

grub_error strings are printed by kern/err.c and are printed after ":"
like:
Error: %s

(talking from memory)

One commit from Robert did:
----
   if (argc == 0)
   -    return grub_error (GRUB_ERR_BAD_ARGUMENT, "no initrd specified");
   +    return grub_error (GRUB_ERR_BAD_ARGUMENT, "No initrd specified");
         
   if (!loaded)
   -    return grub_error (GRUB_ERR_BAD_ARGUMENT, "You need to load the kernel 
first.");
    +    return grub_error (GRUB_ERR_BAD_ARGUMENT, "You need to load Linux 
first.");
----

This should not be capitalised.

address@hidden
Wed 2010-01-20 01:29:06 +0000
----
        * loader/mips/linux.c (grub_cmd_initrd)
        (GRUB_MOD_INIT(linux)): Adjust and gettextize a few strings.
----

So:
a) if someone has a better idea to avoid this mistake again than paying
attention I can implement.
b) Robert: I reverse it, fine?

Cheers,

-- 
Carles Pina i Estany
        http://pinux.info




reply via email to

[Prev in Thread] Current Thread [Next in Thread]