Re: keyboard layout patches

[Robert Millan]

On Mon, Jan 18, 2010 at 08:04:35PM +0000, Carles Pina i Estany wrote:
> On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote:
> 
> > +  grub_util_write_image ("GRUBLAY", 7, fp);
> > +  grub_util_write_image ((char *) &version, 4, fp);
> > 
> > should be macroified and put somewhere in a header instead of duplicating
> 
> I agree. Any reason that I don't see that in util/grub-mkfont.c:
> 
>   grub_util_write_image ("FILE", 4, file);
>   grub_util_write_image ("PFF2", 4, file);
> 
> and then in font/font.c:
> 
>   static const char section_names_file[4] = { 'F', 'I', 'L', 'E' };
>   static const char pff2_magic[4] = { 'P', 'F', 'F', '2' };
> 
> ?
> 
> If should be in a macro (as I think so) I will fix after finishing other
> things.

Yeah it should.

-- 
Robert Millan

  "Be the change you want to see in the world" -- Gandhi