[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] switch from sprintf to asprintf and snprintf
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] switch from sprintf to asprintf and snprintf |
Date: |
Sun, 17 Jan 2010 12:59:26 +0100 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20091109) |
Colin Watson wrote:
> On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder'
> Serbinenko wrote:
>
>> +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...)
>> + __attribute__ ((format (printf, 1, 2)));
>>
>
> It's very confusing that you've made grub_asprintf have a dramatically
> different interface from asprintf. Perhaps you could call this
> grub_xasprintf instead? (Although I notice that it doesn't die when
> malloc fails, but merely returns NULL.)
>
What about grub_aprintf ?
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] switch from sprintf to asprintf and snprintf,
Vladimir 'φ-coder/phcoder' Serbinenko <=