[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Check for device type (block/character) in grub-setup?
From: |
Robert Millan |
Subject: |
Re: Check for device type (block/character) in grub-setup? |
Date: |
Sun, 3 Jan 2010 17:52:19 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Jan 03, 2010 at 03:54:49AM +0100, Grégoire Sutre wrote:
> Hi,
>
> I'm wondering why there is no check for device type (block/character) in
> grub-setup.c whereas the function probe() in grub-probe.c exits with
> error if the device is not of the expected type. Shouldn't there be a
> similar check in grub-setup?
Yes.
> I guess that a similar
> behavior could be observed on FreeBSD, but I can't actually test this.
Please make the code generic if possible (i.e. accept both character and
block devices).
--
Robert Millan
"Be the change you want to see in the world" -- Gandhi