Re: [PATCH] spaces (label, UUID)

[Robert Millan]

On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote:
> === modified file 'normal/misc.c'
> --- normal/misc.c     2009-12-20 23:32:15 +0000
> +++ normal/misc.c     2009-12-28 01:15:34 +0000
> @@ -68,7 +68,10 @@ grub_normal_print_device_info (const cha
>             if (grub_errno == GRUB_ERR_NONE)
>               {
>                 if (label && grub_strlen (label))
> -                 grub_printf_ (N_("- Label %s"), label);
> +                 {
> +                   grub_putchar (' ');
> +                   grub_printf_ (N_("- Label \"%s\""), label);
> +                 }
>                 grub_free (label);
>               }
>             grub_errno = GRUB_ERR_NONE;
> @@ -81,6 +84,7 @@ grub_normal_print_device_info (const cha
>             if (grub_errno == GRUB_ERR_NONE)
>               {
>                 grub_unixtime2datetime (tm, &datetime);
> +               grub_putchar (' ');
>                 grub_printf_ (N_("- Last modification time %d-%02d-%02d "
>                              "%02d:%02d:%02d %s"),
>                              datetime.year, datetime.month, datetime.day,

Why not just add a space before the -?

Uhm, I guess I know the answer in advance :-)

Carles, we shouldn't avoid changing translatable strings at the cost of
making the code bigger or less efficient.  It's not hard for translators
to reuse the old string.

I notice that you committed it already.  Please can you adjust?

-- 
Robert Millan

  "Be the change you want to see in the world" -- Gandhi