Re: [PATCH 2/3] Compilation with external intl library

[Robert Millan]

On Thu, Dec 31, 2009 at 05:55:04PM +0100, Yves Blusseau wrote:
> +/* Disabled NLS.
> +   The casts to 'const char *' serve the purpose of producing warnings
> +   for invalid uses of the value returned from these functions.
> +   On pre-ANSI systems without 'const', the config.h file is supposed to
> +   contain "#define const".  */
> +# define gettext(Msgid) ((const char *) (Msgid))
> +# define grub_gettext(str) ((const char *) (str))

This should have #ifdef GRUB_UTIL / #else.

> +  grub_util_init_nls();

Please add a space in-between (in this and other calls).

> diff --git a/util/mkisofs/mkisofs.h b/util/mkisofs/mkisofs.h
> index 79ae502..55b4aa6 100644
> --- a/util/mkisofs/mkisofs.h
> +++ b/util/mkisofs/mkisofs.h
> @@ -30,10 +30,7 @@
>  #include <prototyp.h>
>  #include <sys/stat.h>
>  
> -#include <locale.h>
> -#include <libintl.h>
> -#define _(str) gettext(str)
> -#define N_(str) str
> +#include <grub/i18n.h>

Please don't make mkisofs depend on GRUB headers.  It's a bit confusing,
but mkisofs is supposed to be a separate package.

-- 
Robert Millan

  "Be the change you want to see in the world" -- Gandhi